Skip to content

Initial POC for metric aggregations#35

Draft
CrAzE124 wants to merge 1 commit intombuhot:masterfrom
CrAzE124:add-metrics-aggregations
Draft

Initial POC for metric aggregations#35
CrAzE124 wants to merge 1 commit intombuhot:masterfrom
CrAzE124:add-metrics-aggregations

Conversation

@CrAzE124
Copy link

Still a WIP - submitting for some guidance in terms of

  • module layout (aggregations.metrics)?
  • completeness (should each agg be feature complete - i.e. including "scripts" and related concepts?)

If this looks good I'll move on to the other metric aggs! Looking forward to assisting on this.

@CrAzE124 CrAzE124 mentioned this pull request Jun 19, 2019
@mbuhot
Copy link
Owner

mbuhot commented Jun 19, 2019

Looks pretty good to me 👍

For the package name, I’d prefer we either

  1. use mbuhot.eskotlin.aggregation to match the existing aggregation builders

Or 2) move the filter / nested aggregation builders into a mbuhot.eskotlin.aggregations.bucket package .

@nzcoffeem what do you think?

As for completeness, feel free to implement as much functionality as you require for your own projects and document any limitations in the code.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants