Fix archery entity tracking failing often on Folia#5260
Merged
nossr50 merged 1 commit intomcMMO-Dev:masterfrom Feb 13, 2026
Merged
Fix archery entity tracking failing often on Folia#5260nossr50 merged 1 commit intomcMMO-Dev:masterfrom
nossr50 merged 1 commit intomcMMO-Dev:masterfrom
Conversation
Member
|
I appreciate all the work you contribute, thanks for another PR 🫡 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue that this PR aims to solve is an IllegalStateException thrown by folia when getEntityId is called on an entity in a different region, this can happen whenever incrementTrackerValue is called with more than two TrackedEntity instances in the list.
I also updated the class to use a map instead of a list, since it's a simpler and more efficient way to do this.