Add latest releases and a script to get the commit hashes.#3
Add latest releases and a script to get the commit hashes.#3daxgames wants to merge 27 commits intomcgitty:mainfrom
Conversation
|
Sorry for the delay. Let me have a look in the coming days. However, since this is for git-bash, it makes more sense to have an automated script in bash instead of Windows CMD. |
|
The cmd script is just a shim for a powershell script that does all the work. Honestly you could do the same and write a |
|
Added an I chose to write this in |
|
I suggest testing your code more. In your I happened to test the following command in cygwin, and the prompt "Enter index of release to use (empty to abort):" was not displayed: |
|
I do not use Cygwin so I do not have it installed. I would not expect: To display anything. Not sure I would ever have thought of testing it that way. But Has been tested from git bash and works as expected. |
1 similar comment
|
I do not use Cygwin so I do not have it installed. I would not expect: To display anything. Not sure I would ever have thought of testing it that way. But Has been tested from git bash and works as expected. |
|
I will look at the other. |
|
The problem is with the shim files and not the ps1 script, so I removed the shims. |
|
Do the following from command window cmd.exe: |
|
Thanks for pushing for a fix. I was busy on other things last time I looked at it and there indeed was a bug when only one candidate was returned. I also:
In my testing it works as expected now. |
|
Never mind I think I see one more issue. Will let you know when it is right. |
|
Should be fixed now. Please let me know. |
|
Thanks for the update. I have my minimal but concise style of wording, so I will likely change text when I do merge. However, my tests focus on: 1) select the commit ID the same way as the manual-way; 2) the script doesn't crash if matching versions do exist. For focus 1), the easy way is to find an existing release in the version file and see if the script outputs the same commit ID. So far it is working for a few old versions I tried, but I will test more, including those not in the version file. For focus 2), I still encounter crashes when it shouldn't. Here are some examples (always select 1): Seeing errors from above cases, I want to suggest a change. Your script seems to print the most recent version first for multiple match. Please make the default selection 1. My intend for the version file is not to capture all possible releases, but only the highest revision of "n.mm.x.y" at the time. Also, the script is non-destructive, so idea of "Abort" is not necessary. |
|
@mcgitty We have conflicting goals but I can accomadate and make it work both ways. I can add My testing always uses a three part semantic version and I was using I did get different hashes than in the file for some of the I never did anything with |
|
@mcgitty I think this is as close to what we both are looking for. I renamed
Please lt me know if you see anything else. |
|
I think I am done. |
|
Still not happy cleaning it up. |
|
Now I'm done |
|
Now I am done. |









I have tested the added hashes and they result in a working pacman install with 2.52.0.1
I also have a
install_pacman.shscript that works but it does not make sense to add it to this repo or if it does to you I can add amcgittyversion of it here also. We are considering adding pacman to Cmder as a default component.See: cmderdev/cmder#3060
See usage in edited
README.md