Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

feat: Add vanilla sound selection functionality#8

Closed
Sweatent wants to merge 5 commits intomchorse:masterfrom
Sweatent:vanilla-sound-pr
Closed

feat: Add vanilla sound selection functionality#8
Sweatent wants to merge 5 commits intomchorse:masterfrom
Sweatent:vanilla-sound-pr

Conversation

@Sweatent
Copy link
Copy Markdown
Contributor

  • Add UIVanillaSoundOverlayPanel for selecting vanilla Minecraft sounds
  • Integrate vanilla sound selection into UISoundOverlayPanel with right-click context menu
  • Add visual hint when sound list is empty to guide users
  • Automatically copy selected vanilla sounds to mod's audio directory
  • Refresh sound list after adding vanilla sounds
  • Add necessary localization keys for UI text
  • Format code and add concise comments for better maintainability"

@mchorse
Copy link
Copy Markdown
Owner

mchorse commented Sep 4, 2025

I checked it, and it doesn't appear to work in development or in Modrinth or MultiMC launchers. I don't think this is acceptable for me. I'll keep the pull request open. Maybe you'll find a way to find another way to load those sounds (for example through ResourceManager system) or find a way to recursively search for assets/index/ folder.

@mchorse mchorse closed this Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants