This repository was archived by the owner on Jan 9, 2026. It is now read-only.
feat: Add vanilla sound selection functionality#8
Closed
Sweatent wants to merge 5 commits intomchorse:masterfrom
Closed
feat: Add vanilla sound selection functionality#8Sweatent wants to merge 5 commits intomchorse:masterfrom
Sweatent wants to merge 5 commits intomchorse:masterfrom
Conversation
Contributor
Sweatent
commented
Aug 15, 2025
- Add UIVanillaSoundOverlayPanel for selecting vanilla Minecraft sounds
- Integrate vanilla sound selection into UISoundOverlayPanel with right-click context menu
- Add visual hint when sound list is empty to guide users
- Automatically copy selected vanilla sounds to mod's audio directory
- Refresh sound list after adding vanilla sounds
- Add necessary localization keys for UI text
- Format code and add concise comments for better maintainability"
Owner
|
I checked it, and it doesn't appear to work in development or in Modrinth or MultiMC launchers. I don't think this is acceptable for me. I'll keep the pull request open. Maybe you'll find a way to find another way to load those sounds (for example through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.