This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Security: add server-side permission checks to NPC packet handlers#40
Open
MRkto wants to merge 1 commit intomchorse:masterfrom
Open
Security: add server-side permission checks to NPC packet handlers#40MRkto wants to merge 1 commit intomchorse:masterfrom
MRkto wants to merge 1 commit intomchorse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added server-side permission checks across NPC packet handlers to prevent unauthorized manipulation. Previously,
NpcStatecould allow arbitrary code execution on the server if an NPC was presentChanges
Added Op/Creative check to
ServerHandlerNpcState,ServerHandlerNpcList, andServerHandlerNpcToolAdded isRiding check to
ServerHandlerNpcJumpSecurity impact
Severity: High for the
ServerHandlerNpcState(prevents potential script injection)Other fixes: lowered-risk integrity/permission issues