replace jxon with fast-xml-parser#219
Merged
mcohen01 merged 1 commit intomcohen01:masterfrom Feb 27, 2024
Nhasa:replace-jxon-package
Merged
replace jxon with fast-xml-parser#219mcohen01 merged 1 commit intomcohen01:masterfrom Nhasa:replace-jxon-package
mcohen01 merged 1 commit intomcohen01:masterfrom
Nhasa:replace-jxon-package
Conversation
gschechter
approved these changes
Feb 1, 2024
gschechter
left a comment
gschechter
left a comment
There was a problem hiding this comment.
This is great hopefully @Nhasa can get this in for the npmjs to pick up
|
@mcohen01 are you available to review the PR that is here to avoid a published CVE related to the use of jxon? We're looking at options to not have this CVE in our application libraries. |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #218
Hi @mcohen01 ,
Awesome work on the SDK firstly 👏 Not sure if you already have a solution implemented to tackle the issue #218 and have not published yet for the developer community.
It seems there's no response for this PR tyrasd/jxon#55. So, I'm suggesting to replace jxon to fast-xml-parser instead.
Look forward to your feedback. Thanks for your time.