Ed25519 layers reduced #2556
Open
Ed25519 layers reduced #2556
+23
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
ed25519-layers-reduced
branch
from
9271a4a to
8f49ad9
Compare
nordicjm
reviewed
Nov 21, 2025
boot/bootutil/src/image_ed25519.c
Outdated
| * calls bootutil_verify to do the signature verification. | ||
| /* Signature verification function. | ||
| * Verifies message with provided signature. | ||
| * When compiled without MCUBOOT_SIGN_PURE, the funciton expects |
de-nordic
force-pushed
the
ed25519-layers-reduced
branch
from
8f49ad9 to
9d0f2c9
Compare
With small changes the bootutil_verify_sig can now be used for the same purpose as bootutil_verify_img. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
No longer needed. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
ed25519-layers-reduced
branch
from
9d0f2c9 to
0626123
Compare
nordicjm
reviewed
Dec 3, 2025
boot/bootutil/src/image_ed25519.c
Outdated
Comment on lines
88
to
89
| uint8_t *sig, size_t slen, | ||
| uint8_t key_id) |
Collaborator
There was a problem hiding this comment.
alignment off (can even move to less lines)
Reduce layers of calls. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
force-pushed
the
ed25519-layers-reduced
branch
from
0626123 to
1586e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce call path.
Cuts down ~76 bytes from nrf54l15 build with ed25519 signature (non-pure).
All three commits will be squashed into one.