Skip to content

Conversation

@chvink
Copy link
Contributor

@chvink chvink commented Apr 24, 2020

No description provided.

Copy link

@tahandy tahandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only big thing is enforcing that bufferSize > 0. Everything else are just nits.

Looks good! 💯 🔥

@tahandy
Copy link

tahandy commented Apr 29, 2020

One last thing, you'll want to drop the license at the top of these files. I've updated it to be relevant to 2020:

/* =========================================================================
 * This file is part of mem-c++
 * =========================================================================
 *
 * (C) Copyright 2004 - 2020, Radiant Geospatial Solutions
 *
 * mem-c++ is free software; you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this program; If not,
 * see <http://www.gnu.org/licenses/>.
 *
 */

chvink added 3 commits May 5, 2020 14:08
1) Handle maxNumElts = 0
2) Ctxt around exceptions
3) License banner
4) Formatting, doxygen, etc
@chvink
Copy link
Contributor Author

chvink commented May 5, 2020

Should be all set

@jmrandol
Copy link

jmrandol commented Sep 8, 2020

Any reason why this isn't merged?

@chvink
Copy link
Contributor Author

chvink commented Sep 8, 2020

I'm not sure if anyone is going to be able to get around to using this in the spot it was originally intended any time soon, but I think it can be merged anyway on the off chance someone wants a circular buffer for something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants