-
Notifications
You must be signed in to change notification settings - Fork 18
Added circular buffer #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
tahandy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only big thing is enforcing that bufferSize > 0. Everything else are just nits.
Looks good! 💯 🔥
|
One last thing, you'll want to drop the license at the top of these files. I've updated it to be relevant to 2020: |
1) Handle maxNumElts = 0 2) Ctxt around exceptions 3) License banner 4) Formatting, doxygen, etc
|
Should be all set |
|
Any reason why this isn't merged? |
|
I'm not sure if anyone is going to be able to get around to using this in the spot it was originally intended any time soon, but I think it can be merged anyway on the off chance someone wants a circular buffer for something. |
No description provided.