Swapped basename fallback function from os.tempnam to uuid #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset removes the references to os.tempnam in some of the sample code used as a fallback when no filename is provided.
os.tempnam has been deprecated since Python 3.0 and was considered a symlink vulnerability prior to that:
https://docs.python.org/2.7/library/os.html
While the function is not actually used to generate temporary files in Nitro as intended, it still appears in SonarQube scans as a vulnerability.
Swapped to uuid to provide a non-deprecated function that provides unique file names while also not thrown as a vulnerability in SonarQube.
Test Steps:
os.path.basename(fileName)from the CLI calls to force it to hit the fallback