Open
Conversation
Collaborator
|
The problem with this patch is the "FIXME" and the printf's ... |
Collaborator
|
So looks better, but I don't really know enough about this code to review it on my own. Would like to hear others' opinions. |
rathann
reviewed
Mar 24, 2021
| g_set_error(err, LDM_ERROR, LDM_ERROR_NOT_LDM, | ||
| "%s does not contain LDM metadata", path); | ||
| return FALSE; | ||
| default: |
There was a problem hiding this comment.
You're mixing tabs and spaces in these 3 lines.
Author
There's only four primary partitions on MBR so it works. More details on LDM/MBR here similar fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated ldm.c to check other partitions for the LDM signature.
The drive has an OEM/Dell partition which Windows handles but confuses the tool
ldmtool now finds the disk and seems to work