Fix and improve view-transition-class page#43836
Merged
Conversation
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-05-07 12:12:56) |
pepelsbey
reviewed
Apr 22, 2026
Member
pepelsbey
left a comment
There was a problem hiding this comment.
Good catch! Thank you 🙂
I would go the extra step and make sure it’s clear, both from the description and additional examples. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects several issues related to
custom-identvalue description in view-transition-class doc (1 commit for each, in this order):custom-identare supported but apart from the formal syntax the first sentence of the doc implies that only one class can be given.Motivation
I came to this article to know whether I could use several
custom-idents on one element and I missed the+in the formal syntax but nowhere else in the doc this is said and I feel readers could benefit from a bit of redundancy and more clarity.The value description field was plain wrong, the info is true for
view-transition-namebut not forview-transition-classso it contributes to keep the confusion going between these two.Related issues and pull requests
Fixes #43784