Skip to content

Fix and improve view-transition-class page#43836

Merged
pepelsbey merged 7 commits intomdn:mainfrom
TGianella:fix/43784-view-transition-class
May 7, 2026
Merged

Fix and improve view-transition-class page#43836
pepelsbey merged 7 commits intomdn:mainfrom
TGianella:fix/43784-view-transition-class

Conversation

@TGianella
Copy link
Copy Markdown
Contributor

@TGianella TGianella commented Apr 17, 2026

Description

Corrects several issues related to custom-ident value description in view-transition-class doc (1 commit for each, in this order):

  • It does not need to be unique
  • It does not cause the element to participate in a separate view-transition group
  • Several custom-ident are supported but apart from the formal syntax the first sentence of the doc implies that only one class can be given.

Motivation

I came to this article to know whether I could use several custom-idents on one element and I missed the + in the formal syntax but nowhere else in the doc this is said and I feel readers could benefit from a bit of redundancy and more clarity.

The value description field was plain wrong, the info is true for view-transition-name but not for view-transition-class so it contributes to keep the confusion going between these two.

Related issues and pull requests

Fixes #43784

@TGianella TGianella requested a review from a team as a code owner April 17, 2026 07:52
@TGianella TGianella requested review from pepelsbey and removed request for a team April 17, 2026 07:52
@github-actions github-actions Bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Preview URLs (1 page)

(comment last updated: 2026-05-07 12:12:56)

Copy link
Copy Markdown
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you 🙂

I would go the extra step and make sure it’s clear, both from the description and additional examples. What do you think?

Comment thread files/en-us/web/css/reference/properties/view-transition-class/index.md Outdated
@TGianella TGianella requested a review from pepelsbey April 22, 2026 16:59
@github-actions github-actions Bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels May 6, 2026
@TGianella TGianella changed the title Fix view-transition-class custom-ident description Fix and improve view-transition-class page May 6, 2026
Copy link
Copy Markdown
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you 🙂

@pepelsbey pepelsbey merged commit 7447816 into mdn:main May 7, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

view-transition-class <custom-ident> value description is wrong

3 participants