FF151 Element.requestFullScreen() option.keyboardLock docs#43884
Merged
FF151 Element.requestFullScreen() option.keyboardLock docs#43884
Conversation
8 tasks
Contributor
|
Preview URLs (1 page) (comment last updated: 2026-05-08 00:03:00) |
hamishwillee
commented
Apr 21, 2026
hamishwillee
force-pushed
the
ff151_requestfullscreen_keyboardlock
branch
2 times, most recently
from
490d761 to
6380870
Compare
pepelsbey
reviewed
May 5, 2026
Member
pepelsbey
left a comment
pepelsbey
left a comment
There was a problem hiding this comment.
Looks good! Thank you 🙂
A few suggestions, mostly for consistency.
Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
hamishwillee
force-pushed
the
ff151_requestfullscreen_keyboardlock
branch
from
f2b9e61 to
39c2307
Compare
Collaborator
Author
|
Thanks @pepelsbey - Agree with/accepted all your suggestions. Ready for another look. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF151 adds support for the
options.keyboardlockproperty to be passed in the options object toElement.requestFullScreen()in https://bugzilla.mozilla.org/show_bug.cgi?id=2032302.This allows use cases such as games to use the Esc key (say) without exiting full screen mode.
The PR updates the docs for
Element.requestFullScreen()with the new option and a new example.It also fixes up layout issues and restructures the document to current standards - adding things like permissions policy integration and so on.
Note that right now the standard is in flux. This is broadly supprted on both FF and Safari in the same way, but things like what key is pressed to exit keyboard lock, what additional keys are intercepted, and so on, are not specified at all (and not likely to be).
Related docs work can be tracked in #43868