Ff151 CSSContainerRules.conditions docs#43995
Open
hamishwillee wants to merge 11 commits intomdn:mainfrom
Open
Ff151 CSSContainerRules.conditions docs#43995hamishwillee wants to merge 11 commits intomdn:mainfrom
hamishwillee wants to merge 11 commits intomdn:mainfrom
Conversation
8 tasks
Contributor
|
Preview URLs (4 pages)
(comment last updated: 2026-05-08 04:23:19) |
Contributor
|
Looks good to me. |
chrisdavidmills
requested changes
May 4, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
@hamishwillee mostly looking good, but I've thrown a few comments at you.
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 4, 2026
hamishwillee
commented
May 5, 2026
hamishwillee
commented
May 5, 2026
hamishwillee
commented
May 5, 2026
Collaborator
Author
|
Thanks for the review @chrisdavidmills ! Ready for another look. Accepted almost everything and tried to roll it out. |
chrisdavidmills
requested changes
May 5, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
@hamishwillee a bunch more comments for you, sorry about that! This is mostly just grammar stuff now.
| ``` | ||
|
|
||
| > [!NOTE] | ||
| > On browsers that don't support `conditions`, you may be able to use {{domxref("CSSContainerRule.containerName")}} and {{domxref("CSSContainerRule.containerQuery")}}, provided that the `@container` only specifies one container condition. |
Contributor
There was a problem hiding this comment.
Suggested change
| > On browsers that don't support `conditions`, you may be able to use {{domxref("CSSContainerRule.containerName")}} and {{domxref("CSSContainerRule.containerQuery")}}, provided that the `@container` only specifies one container condition. | |
| > In browsers that don't support `conditions`, you may be able to use {{domxref("CSSContainerRule.containerName")}} and {{domxref("CSSContainerRule.containerQuery")}} to return container name and query information, provided that the `@container` only specifies one container condition. |
Collaborator
Author
|
Thanks very much for the exhaustive (ing?) review @chrisdavidmills . I've accepted all, pretty much without change. |
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
53c58a8 to
f46b78d
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds docs for
CSSContainerRules.conditionsthat will be supported from FF151.This is quite difficult to do (i.e. a compromise) because
conditionsis a spec update that supersedes the old containerQuery and containerName. It provides support for multiple container conditions in a container rule, mirroring changes to@container.SO you have this new thing that you should use, but it won't work in older browsers. Further, if you try create an
@containerthat has multiple container queries that will silently fail in the CSS, but when you try access the rule in code you'll get anundefinedinstead ofCSSContainerRules.Upshot, changes to the meanings of all the variables even though not yet broad browser support. I have tried to do this by reflecting the current spec and adding clear notes about the issues.
@dletorey You're doing the corresponding
@containerwork in #43862. Some of this might change a bit based on how you create your definitions - i.e. I'd link to specific parts of your docs rather than making my own terms if there were link targets.Would appreciate you scanning this at least!
Related cocs works can be tracked in #43864