Merged
Conversation
caugner
commented
Oct 16, 2025
We will remove this workflow.
argl
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit
permissions:configuration to workflow files that don't already have permissions defined either at the workflow level or for all jobs.secrets.GITHUB_TOKENorgithub.token, setspermissions: {}to restrict all permissions.permissions:with required permissions.Motivation
Security best practice to explicitly declare
GITHUB_TOKENpermissions instead of relying on default permissions, following the principle of least privilege by ensuring workflows only have the permissions they actually need.Additional details
See: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
Related issues and pull requests
Part of mdn/fred#924.