fix(left-sidebar): text alignment of current page#1221
Draft
fix(left-sidebar): text alignment of current page#1221
Conversation
Author
|
I can move this to draft while waiting for #1154. |
Contributor
|
59bfd7e was deployed to: https://fred-pr1221.review.mdn.allizom.net/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR adds a negative margin to the
<em>element which houses the current link (<a aria-current="page">) insideleft-sidebar. The value of this negative margin is calculated as the sum of padding and border width.It seems like this codebase mixes logical properties with physical properties everywhere, which is confusing and probably not intentional. For this PR, I've converted the
border-leftdeclaration within the same ruleset into its logical equivalent (border-inline-start) and also grouped it together with thepadding-inlineandmargin-inline-startdeclarations for better readability / local reasoniing.Motivation
This change was necessary for optical left alignment of all items within the same list.
Additional details
N/A
Related issues and pull requests
N/A