Draft
Conversation
Contributor
|
68408a2 was deployed to: https://fred-pr1279.review.mdn.allizom.net/ |
caugner
commented
Feb 4, 2026
caugner
commented
Feb 4, 2026
caugner
changed the title
Add missing toggle event handler for data-glean-toggle-open attribute. Fixes #1035
caugner
force-pushed
the
add-missing-measurements
branch
from
7f33adc to
e453d13
Compare
Instead, measure the top nav login in the `user-menu` component, which does NOT use the `login-button` component.
caugner
commented
Feb 4, 2026
Contributor
Author
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
Reviewed all changes, will test next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds several missing Glean measurements, and corrects some.
Motivation
Ensure we can make data-driven decisions about the affected features.
Additional details
Related issues and pull requests
Related to #647.
Fixes several issues, mentioned directly in the commits.