fix(play-console): preserve whitespace#674
Open
OnkarRuikar wants to merge 11 commits intomdn:mainfrom
Open
Conversation
caugner
reviewed
Sep 1, 2025
caugner
requested changes
Sep 3, 2025
components/play-console/element.css
Outdated
| } | ||
|
|
||
| code { | ||
| pre { |
Contributor
Contributor
Author
There was a problem hiding this comment.
Just white-space: preserve isn't cutting it. The > and ####... are getting rendered on different lines.
We need <li> to not wrap and the text content to wrap. Let me know how the latest commit fares:
Code used
console.log(" abcd d c ");
console.log(" abcd \nd c ");
console.log("a".repeat(300));
caugner
requested changes
Sep 10, 2025
Contributor
caugner
left a comment
There was a problem hiding this comment.
Let's use a fixed width for the line indicator, and reuse that width for calculating the code with.
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Contributor
|
bf48e08 was deployed to: https://fred-pr674.review.mdn.allizom.net/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The output lines are displayed only in
<code>blocks, so the HTML rendering is collapsing the whitespaces. As the content is only the text log strings, using only inline<pre>blocks solves the problem.Additional details
Code used to test:
Before fix
After fix
Related issues and pull requests
Fixes #668