chore(baseline): don't depend on web-features for types#771
Merged
Conversation
it's more accurate to get these from rari, since that's where we load the data from
Contributor
|
067149b was deployed to: https://fred-pr771.review.mdn.allizom.net/ |
caugner
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this when testing if the schema changes in mdn/rari#312 cause any issues in fred: they don't, but I noticed that we weren't consistently using the
raritypes, and were using some types directly fromweb-features. We should derive them from our rari types instead.Tested locally with
npm run tscandnpm run start.