Open
Conversation
brysonbw
force-pushed
the
allow-report-hint-banner-to-be-dismissed
branch
from
2d3cf8e to
f52688e
Compare
Contributor
|
@brysonbw Note that in conventional commits there is no space between the change type and the scope, see this example. |
brysonbw
force-pushed
the
allow-report-hint-banner-to-be-dismissed
branch
from
f52688e to
7139f2c
Compare
brysonbw
changed the title
brysonbw
force-pushed
the
allow-report-hint-banner-to-be-dismissed
branch
from
2ebbd7b to
686ee57
Compare
brysonbw
changed the title
brysonbw
force-pushed
the
allow-report-hint-banner-to-be-dismissed
branch
from
686ee57 to
d09ea91
Compare
caugner
changed the title
caugner
requested changes
Nov 4, 2025
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
Let's reduce this PR to updating the design of the banner, i.e. removing the dismiss part.
Contributor
|
dd47e77 was deployed to: https://fred-pr892.review.mdn.allizom.net/ |
caugner
reviewed
Jan 30, 2026
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
Overall looks much better to me than the status quo, but could the HTML box and the right box be top-aligned on wide screens?
Contributor
Author
Something like this? 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Additional details
Before
report-hint-banner-before.mov
report-hint-banner-dismiss-on-clear-before.mov
After
report-hint-banner-after.mov
Related issues and pull requests
Seeing something inappropriate?hint doesn't have dismiss/close button #710Seeing something inappropriate?hint doesn't go away after reporting #711