fix(curriculum): fix core module orange underline extending to extens…#898
Open
fix(curriculum): fix core module orange underline extending to extens…#898
Conversation
Contributor
|
bf48e08 was deployed to: https://fred-pr898.review.mdn.allizom.net/ |
caugner
requested changes
Jan 30, 2026
Contributor
There was a problem hiding this comment.
Thanks for looking into this. Now that the review deployment works on fred PRs, I finally took a look: https://fred-pr898.review.mdn.allizom.net/en-US/curriculum/#modules
Unfortunately, it doesn't look right for the "Extensions" tab yet:
Maybe the pre-Fred version of this page in the Web Archive gives indications of what we're missing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Screen recordings
Before
module-orange-underline-before.mov
After
module-orange-underline-after-1.mov
Related issues and pull requests