Skip to content

chore(css_ref): remove mdn-data dependency#434

Merged
caugner merged 6 commits intomainfrom
369-remove-mdn-data-dependency-from-CSS_ref
Dec 19, 2025
Merged

chore(css_ref): remove mdn-data dependency#434
caugner merged 6 commits intomainfrom
369-remove-mdn-data-dependency-from-CSS_ref

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Dec 12, 2025

Description

Updates the css_ref macro to no longer use mdn-data.

Motivation

We want to archive mdn-data, and this removes one of two usages of mdn-data in Rari, blocking the archival.

Additional details

Related issues and pull requests

Part of #369.

Extracted from #390.

@caugner caugner requested a review from a team as a code owner December 12, 2025 09:07
@caugner caugner requested a review from LeoMcA December 12, 2025 09:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

1f1492b was deployed to: https://rari-pr434.review.mdn.allizom.net/

@caugner caugner force-pushed the 369-remove-mdn-data-dependency-from-CSS_ref branch from da66fc4 to 0d56de0 Compare December 12, 2025 09:19
@LeoMcA
Copy link
Member

LeoMcA commented Dec 12, 2025

Created a very hacky inline diff view in fred to view these changes more easily, and I think it's a shame to lose the qualifier in parentheses after duplicate names:

image

Could we simply check for duplicate names and qualify them with the title of the parent page in parentheses?

@caugner
Copy link
Contributor Author

caugner commented Dec 12, 2025

Could we simply check for duplicate names and qualify them with the title of the parent page in parentheses?

Great catch. 9416d9f adds a suffix for all at-rule descriptors. As far as I can see, this was the old behavior, and there are no more duplicates.

@caugner caugner force-pushed the 369-remove-mdn-data-dependency-from-CSS_ref branch from 4209f87 to 9416d9f Compare December 12, 2025 14:12
@caugner
Copy link
Contributor Author

caugner commented Dec 12, 2025

Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, but has content approved?

@dipikabh
Copy link
Contributor

Spot checked the list for quite a few alphabets. It's looking good!

@caugner caugner merged commit 3ed32ac into main Dec 19, 2025
18 checks passed
@caugner caugner deleted the 369-remove-mdn-data-dependency-from-CSS_ref branch December 19, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants