Conversation
Collaborator
Author
|
The tests are failing because of an issue with downloading/opening the font |
Member
|
Not sure what's going on with the prompt font download, the link works fine if I manually follow it. Any ideas @eytanadler ? |
Collaborator
|
If I follow the same steps in the Prompt install in my terminal locally I get the same error. I think it's related to this issue: google/fonts#7481. |
Member
|
#43 will fix this |
Member
|
Increasing this to a minor version bump since #43 adds functionality to niceplots |
A-CGray
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the minimum packages requirements and version of Niceplots based on this GitHub issue
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable