Conversation
Collaborator
Author
|
It looks like technically Numpy 1.21 does not support python 3.11? Probably on our docker images it works just fine, but in this action environment something in the wheel does not build correctly |
Member
|
We should probably just change the matrix to test numpy 1.21 with python 3.9 and numpy 1.25 with python 3.11, rather than all 4 combinations |
A-CGray
approved these changes
Feb 7, 2025
Member
|
@eirikurj looks like github is still requiring the python 3.8 flake8 check to pass, but we removed it here, I don't think I have the permissions to change the required checks, can you do it? |
Contributor
|
@A-CGray I have updated the requirements. Removed 3.8 and added 3.11. Feel free to merge it when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates the minimum packages requirements and version of pyXDSM based on this GitHub issue
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable