Conversation
Left out internal functions deliberately.
|
Thanks @Aidavdw , docs build failure should be fixed by mdolab/sphinx_mdolab_theme#17 Could you provide some sort of MWE that demonstrates your stubs working that I can run myself? |
|
As this is more of an editor-specific thing, I'm not quite sure what constitutes an MWE. Could you elaborate? |
|
Yeah I just mean could you provide a small pyXDSM example that uses type annotations that I can test in my own editor |
|
Is there a particular reason for using stub files instead of inline type annotations? IMO annotations are much more flexible/readable/maintainable, so unless there is a strong preference I am leaning towards rejecting this PR. I understand that the package to date does not really offer any types, but that's something we can add incrementally, and looks like it's being added as part of #61. In any case, we anticipate substantial code changes so I don't think this PR is worth it anymore. |
Purpose
Fixes #58 by adding .pyi files for XDSM
Expected time until merged
Should be relatively trivial, as it's a single file. Not really that urgent.
Type of change
Technically a feature? Technically documentation? Whatever, type checking!
Testing
Check if pyright and MyPy correctly load and interpret the .pyi file.
I have already tested this on my local machine.
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable