Fix the testing workflow, add equality checks for references#69
Closed
tlong123 wants to merge 5 commits intomdowds:masterfrom
tlong123:master
Closed
Fix the testing workflow, add equality checks for references#69tlong123 wants to merge 5 commits intomdowds:masterfrom tlong123:master
tlong123 wants to merge 5 commits intomdowds:masterfrom
tlong123:master
Conversation
the workflow currently fails due to a lack of python 3.6 on ubuntu-latest. This should allow the action to fall back to building the python version if it's missing
Author
|
@mdowds Any chance you could take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the existing limitations with this library was the ability to query by document reference (which is something you can do in Firestore but not currently in this library). I have added this as it would be super useful. (copied from #68 and added a test)
In addition, the GitHub action for testing is currently broken due to an issue with lack of support for python 3.6 in the latest ubuntu image. I have changed the action to one that will build the python version if it is not able to be installed.