Skip to content

Experimental/newsreader#5

Open
oli-obk wants to merge 4 commits intomeebey:masterfrom
oli-obk:experimental/newsreader
Open

Experimental/newsreader#5
oli-obk wants to merge 4 commits intomeebey:masterfrom
oli-obk:experimental/newsreader

Conversation

@oli-obk
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk commented Sep 21, 2012

No description provided.

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Nov 26, 2013

updated

Comment thread src/Common/RSSFeed.cs Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosmn GPLv2 only is a problem for us, we need v3 compat. Carlos, do you agree to relicense this to "GPLv2 or later"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's make it v2+.

@meebey
Copy link
Copy Markdown
Owner

meebey commented Nov 26, 2013

Please rebase on master which now includes a single MessageBuilder.NormalizeNewlines() implemention.

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Dec 27, 2013

rebased & stuffs

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Dec 27, 2013

oh wait
forgot the gpl version

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Dec 27, 2013

like so?

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Jan 21, 2014

ping?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command.FrontendManager must not be used directly (since hooks), instead use Session.AddMessageToFrontend(). Applies to all use.

@meebey
Copy link
Copy Markdown
Owner

meebey commented Jan 21, 2014

General remarks:

  • rebase, it no longer applies cleanly in master.
  • I haven't checked in detail which features FeedProtocolManager has but I suspect it has less than what my version in Session did. This checking this is a show stopper as you replaced it.
  • make coverage, I doubt this passes a make call
  • It is probably a good idea to support throwing arbitrary feeds into a chat, you should look how I implemented streaming in Twitter here (I am fine though if this is postponed for later): eb64cb2#diff-11f722a95fdf4291f9485bc6a051eb30R28

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Jan 21, 2014

*rebased
*the only "missing" "feature" is that the date of the entry is not displayed behind the title, but rather the normal smuxi timestamps are used
*i am already throwing arbitrary feeds into a protocolchat, the issue is that i'm polling, and not receiving a stream -> i need to poll all feeds that are in the same chat at the same time so the timestamp order doesn't go haywire

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented Jan 21, 2014

i'll have a screenshot for you in a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants