Flip popup to left when it overflows out of window #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks will update the extension, sorry for late reply. Life sometimes does not leave time for anything. |
Author
|
No problem; that's understandable. Looks like this pull request has conflicts with the main repo now. I'll push again after resolving conflicts in my branch. |
Owner
|
@bhch Can you resolve the conflicts |
Author
|
@meetDeveloper Hi, I've resolved the conflicts. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the popup overflows from the window, one needs to scroll to right to bring it into view. This commit flips is to left in those cases.
Also, seems to be a decent fix for #2.