Fix: Tool call context loss after page reload.#32
Merged
mm-zacharydavison merged 7 commits intomainfrom Mar 10, 2026
Merged
Conversation
Contributor
masudahiroto
left a comment
masudahiroto
left a comment
There was a problem hiding this comment.
The bug2 of the bug ticket still exists. Could you check it?
This is a reproduction step.
- Open the chat and send "Add a todo: buy groceries" — the AI executes the
addTodotool. - Confirm the todo appears in the UI.
- Restart the server process.
- Wait for the client to auto-reconnect. (Do not reload the page.)
- Send a new message, and got error.
packages/server/src/server.ts
Outdated
Contributor
There was a problem hiding this comment.
IMO conversation history is managed at both local storage (incomingMessage) and server-side memory (session.conversationHistory), and it makes debugging difficult. Should we simplify this logic so that it always uses incomingMessages?
masudahiroto
approved these changes
Mar 10, 2026
Contributor
masudahiroto
left a comment
masudahiroto
left a comment
There was a problem hiding this comment.
Thank you very much!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in TS-10915 (@meetsmore).
Simply put, tool calls were not persisted in the local storage chat history.
This PR refactors the message storage to make it more consistent (less special cases for specific message types) and fixes the bug.
E2E tests include a new test case for the bug, and are passing.