Skip to content

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Aug 21, 2025

Pull Request

Related issue

Fixes https://linear.app/meilisearch/issue/EXP-257/update-sharding-guide-following-splitting-of-documents (internal)

What does this PR do?

  • Update the network and remote objects with the new fields
  • Update the task object with the new network field
  • Update the guide on sharding

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


## Add documents

Send documents to any instance to have them replicated to the other instances.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered we said people should send to one shard, but my memory is not great today 😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the answer is a bit subtle here.

  1. In v1.19, as long as the client waits for the engine's response before sending another task, they can send their documents to any instance.
  2. However, we might not keep this property in future versions (to be able to dynamically update the network topology), so it might be best to already advise using a single node for writes.

curquiza
curquiza previously approved these changes Aug 25, 2025
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except my comment, lgtm

The message about sharding was not appearing because I had used the NoticeTag as a wrapping tag, which it isn't.
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants