-
Notifications
You must be signed in to change notification settings - Fork 266
Update sharding documentation following Meilisearch's automatic splitting of documents #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
58e6f67
to
e4d259b
Compare
…ment the automatic sharding
|
||
## Add documents | ||
|
||
Send documents to any instance to have them replicated to the other instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remembered we said people should send to one shard, but my memory is not great today 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the answer is a bit subtle here.
- In v1.19, as long as the client waits for the engine's response before sending another task, they can send their documents to any instance.
- However, we might not keep this property in future versions (to be able to dynamically update the network topology), so it might be best to already advise using a single node for writes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except my comment, lgtm
The message about sharding was not appearing because I had used the NoticeTag as a wrapping tag, which it isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Pull Request
Related issue
Fixes https://linear.app/meilisearch/issue/EXP-257/update-sharding-guide-following-splitting-of-documents (internal)
What does this PR do?
network
andremote
objects with the new fieldstask
object with the newnetwork
fieldPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!