expose image load events and bind responders#71
Open
alxyuu wants to merge 1 commit intomeliorence:masterfrom
Open
expose image load events and bind responders#71alxyuu wants to merge 1 commit intomeliorence:masterfrom
alxyuu wants to merge 1 commit intomeliorence:masterfrom
Conversation
alxyuu
commented
Feb 27, 2018
alxyuu
commented
- re-expose load events through gallery (all props were originally passed through in ldn0x7dc's implementation)
- bind responders so TransformableImage can be used directly, they were resolving to the wrong scope when using outside of Gallery
- show error state in the edge case where the dimensions load but the image does not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.