Refactor hashed_fold_scaffold and sha256 in random_split.py and scaffold_network.py#2
Open
lianghsun wants to merge 2 commits intomelloddy:mainfrom
Open
Refactor hashed_fold_scaffold and sha256 in random_split.py and scaffold_network.py#2lianghsun wants to merge 2 commits intomelloddy:mainfrom
lianghsun wants to merge 2 commits intomelloddy:mainfrom
Conversation
Remove the rows with duplicate functions.
Make it consistent with scaffold_network.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I've made some changes to the
random_split.pyandscaffold_network.pyfiles, specifically in thehashed_fold_scaffoldandsha256functions. Here are the main modifications:hashed_fold_scaffoldfunction by utilizing thesha256function and improved the seeding logic.These changes are aimed at streamlining the code and ensuring that the encryption is applied uniformly.
Please review the changes and let me know if any adjustments are required.
Thank you.