Skip to content

Add maxHeaderSize #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2025
Merged

Add maxHeaderSize #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
683367e
Add maxHeaderSize
Maroko Oct 23, 2025
28b0e99
Refactor index.js for improved readability and consistency
Maroko Oct 23, 2025
098fbf8
Revert format
Maroko Oct 23, 2025
f72db68
Implement large header request test in tests.sh
Maroko Oct 23, 2025
24113dc
Replace process.env.MAX_HEADER_SIZE with MAX_HEADER_SIZE
Maroko Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const {
PROMETHEUS_WITH_METHOD = 'true',
PROMETHEUS_WITH_STATUS = 'true',
PROMETHEUS_METRIC_TYPE = 'summary',
MAX_HEADER_SIZE = 1048576
} = process.env

const sleep = promisify(setTimeout);
Expand Down Expand Up @@ -189,22 +190,27 @@ app.all('*', (req, res) => {

});

let sslOpts = {
let httpOpts = {
maxHeaderSize: MAX_HEADER_SIZE
}

let httpsOpts = {
key: require('fs').readFileSync(process.env.HTTPS_KEY_FILE || 'privkey.pem'),
cert: require('fs').readFileSync(process.env.HTTPS_CERT_FILE || 'fullchain.pem')
cert: require('fs').readFileSync(process.env.HTTPS_CERT_FILE || 'fullchain.pem'),
maxHeaderSize: MAX_HEADER_SIZE
};

//Whether to enable the client certificate feature
if(process.env.MTLS_ENABLE){
sslOpts = {
httpsOpts = {
requestCert: true,
rejectUnauthorized: false,
...sslOpts
...httpsOpts
}
}

var httpServer = http.createServer(app).listen(process.env.HTTP_PORT || 8080);
var httpsServer = https.createServer(sslOpts,app).listen(process.env.HTTPS_PORT || 8443);
var httpServer = http.createServer(httpOpts, app).listen(process.env.HTTP_PORT || 8080);
var httpsServer = https.createServer(httpsOpts,app).listen(process.env.HTTPS_PORT || 8443);
console.log(`Listening on ports ${process.env.HTTP_PORT || 8080} for http, and ${process.env.HTTPS_PORT || 8443} for https.`);

let calledClose = false;
Expand Down
11 changes: 11 additions & 0 deletions tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,17 @@ else
exit 1
fi

message " Make request with a large header."
LARGE_HEADER_VALUE=$(head -c 10000 </dev/urandom | base64 | tr -d '\n')
REQUEST=$(curl -s -k -H "Large-Header: $LARGE_HEADER_VALUE" https://localhost:8443/)
if [ $(echo $REQUEST | jq -r '.headers."large-header"') == "$LARGE_HEADER_VALUE" ]; then
passed "Large header test passed."
else
failed "Large header test failed."
echo $REQUEST | jq
exit 1
fi

message " Stop containers "
docker stop http-echo-tests
sleep 5
Expand Down