[WC-3083] fix combobox lazy load on initial load #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where combobox lazy loading was not working properly on initial load. The fix ensures that the lazy loader is properly initialized with a limit before checking for loading status.
- Updated the limit calculation logic to handle Infinity and undefined values more robustly
- Moved the early return for loading status to occur after lazy loader initialization
- Added changelog entry documenting the fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/pluggableWidgets/combobox-web/src/helpers/LazyLoadProvider.ts |
Fixed limit calculation to handle Infinity and undefined values properly during lazy loading |
packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseSingleSelectionSelector.ts |
Moved loading status check after lazy loader initialization to ensure proper setup |
packages/pluggableWidgets/combobox-web/CHANGELOG.md |
Added changelog entry for the lazy load fix |
gjulivan
force-pushed
the
combobox-lazyload-fix
branch
2 times, most recently
from
dc767d7 to
7f21ca5
Compare
gjulivan
force-pushed
the
combobox-lazyload-fix
branch
from
7f21ca5 to
4a6d830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description