This repository was archived by the owner on Jan 3, 2020. It is now read-only.
Fix on dragandrop of new event that the time isn't set correctly#7
Open
joelvdgraaf wants to merge 2 commits intomendixlabs:masterfrom
Open
Fix on dragandrop of new event that the time isn't set correctly#7joelvdgraaf wants to merge 2 commits intomendixlabs:masterfrom
joelvdgraaf wants to merge 2 commits intomendixlabs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 66.82% 66.82%
=======================================
Files 6 6
Lines 217 217
Branches 62 62
=======================================
Hits 145 145
Misses 72 72Continue to review full report at Codecov.
|
Contributor
Andries-Smit
left a comment
Andries-Smit
left a comment
There was a problem hiding this comment.
We have to check if this fix applies to all time views. Day, week, month. Can you confirm? Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a new event in the week view the start and end time isn't set correctly because of a trim-to-day function that removes the time component.
The trim-to-day has been removed in setting start and end attribute of the event.