Skip to content

使用 lucide-react 图标库替换 Emoji 图标#1

Open
lanxkk wants to merge 1 commit intomengjian-github:mainfrom
lanxkk:feature-lucide-icons
Open

使用 lucide-react 图标库替换 Emoji 图标#1
lanxkk wants to merge 1 commit intomengjian-github:mainfrom
lanxkk:feature-lucide-icons

Conversation

@lanxkk
Copy link

@lanxkk lanxkk commented Feb 2, 2026

  1. 使用 lucide-react 图标库替换了 Emoji 图标;
  2. 修改了部分样式。

Copy link
Owner

@mengjian-github mengjian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review 意见

整体方向不错,图标统一、视觉升级是好的。但有几个问题需要修复:

必须修复

  1. Tailwind 语法错误

    • text-primary-40 应为 text-primary/40
    • bg-primary-5 应为 bg-primary/5
  2. 二维码被替换成图标

    • 第 151-165 行:公众号/微信二维码被换成了 <QrCode /> 图标
    • 应该保留真实二维码图片

建议优化

  1. 字体变更:Inter → Space Grotesk 是有意为之吗?

  2. 改动范围:建议拆分成多个小 PR

可以合并

  • 色彩系统扩展很完整
  • 动画效果很平滑
  • 组件封装提高复用性

修复上述问题后可以 Approve 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants