⚡ Bolt: Parallelize Maven sources lookup #102
Conversation
Parallelize the source JAR lookup process in `SourcesJarLocator` to improve resolution performance. This change: - Replaces sequential `stream()` with `parallelStream()` in `fillSourcesAttribute`. - Replaces `HashMap` with `ConcurrentHashMap` in `GraphMemoizator` and `SourcesJarLocator` to ensure thread safety during parallel execution. - Uses `computeIfAbsent` for atomic cache updates in `GraphMemoizator`. This optimization significantly speeds up the resolution phase when checking for source JARs, as these checks involve network I/O.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
💡 What: Parallelized the Maven sources JAR lookup process.
🎯 Why: Source JAR lookup involves network I/O (HEAD requests) which was done sequentially, causing a performance bottleneck.
📊 Impact: Significantly reduces the time taken to resolve dependencies when source JARs are requested, by running network checks in parallel.
🔬 Measurement: Verified by running
bazel test //resolver:sources_locator_testand ensuring all tests pass. Integration tests inexamples/also passed (except Android due to missing SDK).PR created automatically by Jules for task 7205337835606024266 started by @menny