Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

This PR improves performance by parallelizing the source JAR location process.

Changes:

  1. Parallel Execution: Changed SourcesJarLocator.fillSourcesAttribute to use parallelStream(). This allows concurrent HEAD requests to Maven repositories to check for the existence of source JARs, which is a major bottleneck in sequential execution.
  2. Thread Safety:
    • Updated SourcesJarLocator.mURLCache to ConcurrentHashMap to support concurrent access.
    • Updated GraphMemoizator to use ConcurrentHashMap and computeIfAbsent to ensure atomicity and thread safety for the memoization cache.

This change is safe as GraphMemoizator and SourcesJarLocator are now thread-safe, and HttpURLConnection instances are created per request (via ConnectionFactory which opens new connections).


PR created automatically by Jules for task 9088058870112736945 started by @menny

…ance. This involved using `parallelStream()` in `SourcesJarLocator` and switching `mURLCache` and `GraphMemoizator` to `ConcurrentHashMap`. These changes address the bottleneck caused by sequential HEAD requests, resulting in significantly faster execution. You can verify the improvements by running `bazel test //resolver:sources_locator_test`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants