⚡ Bolt: Parallelize source JAR resolution #112
Conversation
💡 What: Switched `SourcesJarLocator` to use `parallelStream()` for fetching source JARs. Updated `GraphMemoizator` and `SourcesJarLocator` caches to use `ConcurrentHashMap` for thread safety. Updated `SourcesLocatorTest` fake implementation to be thread-safe. 🎯 Why: The resolution of source JARs involves blocking network I/O (HTTP HEAD requests). Doing this sequentially for a large number of dependencies is inefficient. Parallelizing this process significantly reduces the total time required to resolve sources. 📊 Impact: - Reduces time to resolve source JARs by up to N times (where N is the number of parallel threads), limited by network bandwidth and pool size. 🔬 Measurement: - Verify by running `bazel test //resolver:sources_locator_test`. - Observable speedup when running `bazel run //:pin` on a project with many dependencies.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Parallelizes the source JAR resolution process to improve performance.
Changes:
resolver/src/main/java/net/evendanan/bazel/mvn/merger/GraphMemoizator.java: ReplacedHashMapwithConcurrentHashMapand usedcomputeIfAbsentfor thread safety.resolver/src/main/java/net/evendanan/bazel/mvn/merger/SourcesJarLocator.java: Switched toparallelStream()andConcurrentHashMap.resolver/src/test/java/net/evendanan/bazel/mvn/merger/SourcesLocatorTest.java: UpdatedFakeOpenerto use thread-safe maps to support parallel test execution.PR created automatically by Jules for task 13109942368099218983 started by @menny