Skip to content

fix: make metadata mento specific#39

Open
philbow61 wants to merge 3 commits intodevelopfrom
fix/NFTMetadata-fixes
Open

fix: make metadata mento specific#39
philbow61 wants to merge 3 commits intodevelopfrom
fix/NFTMetadata-fixes

Conversation

@philbow61
Copy link

Description:
Changed some of the comments to be more mento related. Kept the diff minimal.

@philbow61 philbow61 requested review from a team, Mouradif and bayological February 23, 2026 13:01
@coveralls
Copy link

coveralls commented Feb 23, 2026

Pull Request Test Coverage Report for Build 22356467968

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 97.462%

Totals Coverage Status
Change from base Build 22067362220: -0.001%
Covered Lines: 2304
Relevant Lines: 2364

💛 - Coveralls

nvtaveras
nvtaveras previously approved these changes Feb 24, 2026
@Mouradif
Copy link

Do we want to create our own SVGs here? The current implementation still uses WETH's logo for the collateral and Bold's logo for the debt

@philbow61
Copy link
Author

Do we want to create our own SVGs here? The current implementation still uses WETH's logo for the collateral and Bold's logo for the debt

Thats not really true if you check the deployment repo PR - the token logo SVGs are configurable on deployment.

@Mouradif
Copy link

Do we want to create our own SVGs here? The current implementation still uses WETH's logo for the collateral and Bold's logo for the debt

Thats not really true if you check the deployment repo PR - the token logo SVGs are configurable on deployment.

Ah I just saw that! Awesome

@philbow61 philbow61 changed the base branch from main to develop February 26, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants