fix: display actual vault token balance instead of underlying#89
Merged
Conversation
Previously, vault tokens (sUSDS, stEUR) displayed the underlying asset amount from maxWithdraw() but labeled it with the vault token symbol. This was confusing since "1,050,000 sUSDS" was actually showing USDS. Now we display the actual vault token balance (balanceOf) which matches the symbol shown. The USD value calculation remains correct as it uses the vault token price from DefiLlama. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://analytics-api-preview-feat-fix-susds-amount-a4neydykmq-uc.a.run.app/docs 📝 Details:
This preview will be automatically updated with each new commit to this PR and will be deleted when the PR is merged or closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Affected Assets
Changes
ethereum.balance-fetcher.ts: UsetokenBalancefor display instead ofunderlyingBalancecelo.balance-fetcher.ts: Same change for Celo chainerc20-balance-fetcher.ts: Updated comments to reflect new usageTest plan
🤖 Generated with Claude Code