Conversation
…dates - Remove modal date picker from single account upload button - Calculate start date automatically using same logic as all-accounts sync: - Subsequent sync: last sync date minus lookback period - First sync: account creation date - Fallback: 2 weeks ago - Extract calculateSingleAccountStartDate helper (exported for testing) - Add comprehensive tests for date calculation logic - Remove unused getDateRange import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the modal date picker from single account Questrade sync and automatically determine the start date using the same logic as the all-accounts sync.
Changes
createSingleAccountUploadButtoncalculateSingleAccountStartDate()helper that uses:calculateFromDateWithLookback('questrade', accountId)— last sync date minus lookback periodgetAccountCreationDate()getDateRangeimportMotivation
Previously, single account sync required the user to manually pick dates. The all-accounts sync already had automatic date calculation logic. This change makes the single account sync consistent with that behavior — no user interaction needed for date selection.