fix: resolve duplicate error code in meshkit#904
fix: resolve duplicate error code in meshkit#904parthivsaikia wants to merge 3 commits intomeshery:masterfrom
Conversation
Signed-off-by: PARTHIV PRATIM SAIKIA <parthivsaikia985@gmail.com>
Summary of ChangesHello @parthivsaikia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically eliminates duplicate error codes across the Meshkit codebase. By assigning unique identifiers to errors that previously shared codes, it enhances the reliability and clarity of error reporting, making it easier to diagnose and address issues. The changes ensure that each distinct error condition can be uniquely identified, improving the overall maintainability and robustness of the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively resolves several instances of duplicate error codes within Meshkit by assigning new, unique codes. The changes are logical and the update to helpers/component_info.json to reflect the next available error code is correct. My main feedback is a suggestion to improve maintainability by ensuring that new error codes are assigned sequentially within their respective const or var blocks. This would make the code easier to read and manage in the long run.
Signed-off-by: PARTHIV PRATIM SAIKIA <parthivsaikia985@gmail.com>
…staticcheck Signed-off-by: PARTHIV PRATIM SAIKIA <parthivsaikia985@gmail.com>
Description
Different Meshkit errors were using the same error codes.
e.g.
This PR resolves them by assigning new error codes starting from 11320 to 11334.
This PR fixes #903
Notes for Reviewers
I have updated the error codes by starting from the next available error code i.e. 11320. I have also updated the
helpers/component_info.jsonby stating 11335 as the next available error code.Signed commits