refactor: always attemp to reset readers during retry

[knight42]

No description provided.

[Copilot]

Pull Request Overview

This PR simplifies the retry mechanism by making reader reset functionality unconditional, removing the SetRetryResetReaders API and related configuration. The change makes all io.ReadSeeker implementations (including multipart fields and request bodies) reset automatically on retry attempts.

• Removed SetRetryResetReaders() method and RetryResetReaders field from the Client
• Made reader reset behavior unconditional in the retry logic
• Refactored createHTTPRequest to use http.NewRequestWithContext directly instead of calling WithContext separately
• Increased test tolerance for timing precision from 1ms to 100ms

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
client.go	Removed RetryResetReaders field and SetRetryResetReaders() method
retry.go	Removed ResetMultipartReaders() option function and made reader reset unconditional, removed unused resetReaders field from Options struct
request.go	Removed ResetMultipartReaders option from retry configuration
middleware.go	Refactored to use http.NewRequestWithContext and moved trace initialization before request creation
retry_test.go	Removed SetRetryResetReaders(true) calls from tests and increased timing tolerance to 100ms
request_test.go	Removed SetRetryResetReaders(true) call from test
multipart_test.go	Removed SetRetryResetReaders(true) call from test

Comments suppressed due to low confidence (1)

retry.go:47

• The resetReaders field is no longer used in the Options struct after removing the ResetMultipartReaders() function, but it still exists in the struct definition. This unused field should be removed to maintain code cleanliness.

		resetReaders    bool

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.