Conversation
Signed-off-by: Zack Zeng <jianzeng@meshy.ai>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors multipart form file handling by consolidating duplicate code into a single method. The main purpose is to reduce code duplication by moving multipart field writing logic from util.go into a method on the MultipartField struct.
Key changes:
- Consolidated
addMultipartFormFieldandwriteMultipartFormFilefunctions into a singlewriteToMultipartWritermethod onMultipartField - Added a
Closemethod tomultipartAndPipeWriterfor cleaner resource management - Increased buffer size from 512 bytes to 32KB and reused it with
io.CopyBufferfor better performance
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| multipart.go | Added writeToMultipartWriter method to MultipartField and Close method to multipartAndPipeWriter |
| util.go | Removed addMultipartFormField and writeMultipartFormFile functions and mime/multipart import |
| request.go | Updated to call the new writeToMultipartWriter method instead of addMultipartFormField |
| client.go | Simplified cleanup by calling mpw.Close() instead of closing writers individually |
| util_test.go | Updated tests to use the new method on MultipartField struct |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.