Maint/firebase collection cleanup#448
Maint/firebase collection cleanup#448rugeli wants to merge 5 commits intofeature/server-passed-recipe-jsonfrom
Conversation
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
cellpack/autopack/DBRecipeHandler.py
Outdated
| class DBMaintenance(object): | ||
| """ | ||
| Handles the maintenance of the database. | ||
| Provides utility methods for database operations. |
There was a problem hiding this comment.
nit: it seems like the only things this class does now is return the readme url... I think we could eliminate this class altogether and move the readme url to a constant? If nothing else, it doesn't feel like there's a need for an __init__ function that takes in db_handler anymore, since it doesn't get used?
| file_name, url, db="firebase" | ||
| ) | ||
| if open_results_in_browser: | ||
| if url and open_results_in_browser: |
There was a problem hiding this comment.
nit: we don't use file_name for anything anymore, so we can probably replace line 1391 with _, url = simulariumHelper.store_result_file( ... )
Actually, it looks like simulariumHelper.store_result_file doesn't even need to return file_name anymore, so we could just have that function return url.
ascibisz
left a comment
ascibisz
left a comment
There was a problem hiding this comment.
Love to see PRs like this simplifying the code base!! Added a couple minor comments about more things that we could probably simplify, but this looks good and works for me locally
2 participants
Problem
closes #444
Solution
resultscollectionpost_and_open_fileflow to skip firebase metadata writes, only uploads to s3 and then open new tab in simulariumType of change
Steps to Verify:
examples/packing-configs/upload_and_open_result.json