Open
Conversation
9caafaf to
ed898ab
Compare
ed898ab to
e9f2902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature to support multiple gateways in isti-helm.
Problem Statement:
The legacy Istio Operator (IstioOperator CRD) natively supported defining multiple gateways (ingress, egress, east-west) from a single configuration:
When we migrated from the Istio Operator to istio-helm, the upstream Istio gateway Helm subchart (charts/gateway) only supports a single gateway per chart release. This means customers who previously ran multiple gateways (e.g., ingress + egress, or ingress + east-west) lost the ability to define them from a single values override and would need to deploy separate Helm releases for each gateway.
Solution Approach:
This PR introduces gateway.additional_gateways in the istio-helm-gateway wrapper chart that restores multi-gateway parity with the old Istio Operator — all from a single Helm release and a single values override, while keeping the primary gateway completely unchanged.
Operator -> Helm Mapping:
How To Use Multiple Gateways:
Each entry only needs to specify what differs from
defaults(charts/gateway/values.yaml) — the rest is inherited automatically (resources, security context, Prometheus pod annotations, RBAC, etc.).Which issue(s) this PR fixes:
https://jira.nutanix.com/browse/NCN-112392
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist