Skip to content

Fix wrong add-contacts-into-group usage #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong add-contacts-into-group usage #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions messagebird/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,14 +347,7 @@ def group_update(self, id, name, params=None):
self.request_plain_text('groups/' + str(id), 'PATCH', params)

def group_add_contacts(self, groupId, contactIds):
query = self.__group_add_contacts_query(contactIds)
self.request_plain_text('groups/' + str(groupId) + '?' + query, 'PUT', None)

def __group_add_contacts_query(self, contactIds):
# __group_add_contacts_query gets a query string to add contacts to a
# group. The expected format is ids[]=first-contact&ids[]=second-contact.
# See: https://developers.messagebird.com/docs/groups#add-contact-to-group.
return '&'.join('ids[]=' + str(id) for id in contactIds)
self.request_plain_text(f'groups/{groupId}/contacts/', 'PUT', {'ids': contactIds})

def group_remove_contact(self, groupId, contactId):
self.request_plain_text('groups/' + str(groupId) + '/contacts/' + str(contactId), 'DELETE', None)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ def test_group_add_contacts(self):

Client('', http_client).group_add_contacts('group-id', ['contact-id', 'other-contact-id'])

http_client.request.assert_called_once_with('groups/group-id?ids[]=contact-id&ids[]=other-contact-id', 'PUT',
None)
http_client.request.assert_called_once_with('groups/group-id/contacts/', 'PUT',
{'ids': ['contact-id', 'other-contact-id']})

def test_group_remove_contact(self):
http_client = Mock()
Expand Down