Grad scaling parity between both pp and non-pp #251
Closed
+147
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmfan
force-pushed
the
xmfan/stack/21
branch
from
36903f2 to
7a25b4c
Compare
meta-cla
bot
added
the
CLA Signed
wconstab
reviewed
Nov 15, 2025
| if grad_to_accumulate is not None: | ||
| if unsharded_grad is None: | ||
| unsharded_grad = grad_to_accumulate | ||
| for i in range(len(unsharded_grads)): |
Member
Author
There was a problem hiding this comment.
no longer needed after rebase
wconstab
reviewed
Nov 15, 2025
| n_microbatches=n_microbatches, | ||
| loss_fn=loss_fn, | ||
| backward_requires_autograd=backward_requires_autograd, | ||
| scale_grads=False, |
Contributor
There was a problem hiding this comment.
are you proposing to land this change, or just using it while doing numerics tests?
Member
Author
There was a problem hiding this comment.
i'll change this to only be for numerics test mode maybe? it's either turn this off or emulate the scaling for non-pp
xmfan
force-pushed
the
xmfan/stack/20
branch
2 times, most recently
from
6e72707 to
b8546e1
Compare
Member
Author
|
folded into previous pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Grad scaling parity between both pp and non-pp