Skip to content

[WIP][Draft] PP + simplefsdp #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP][Draft] PP + simplefsdp #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions autoparallel/init_weights.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ def getter(self) -> torch.nn.Parameter:

def setter(self, value: Union[torch.Tensor, torch.nn.Parameter]) -> None:
parallel_value = parallel_model.get_parameter(fqn)
assert isinstance(
parallel_value, DTensor
), "Expected parallel_module params to be DTensors"
# assert isinstance(
# parallel_value, DTensor
# ), "Expected parallel_module params to be DTensors"
_copy_set_value_to_dtensor(fqn, parallel_value, value)

return property(getter, setter)
Expand All @@ -66,9 +66,9 @@ def getter(self) -> torch.Tensor:

def setter(self, value: torch.Tensor) -> None:
parallel_value = parallel_model.get_buffer(fqn)
assert isinstance(
parallel_value, DTensor
), "Expected parallel_module params to be DTensors"
# assert isinstance(
# parallel_value, DTensor
# ), "Expected parallel_module params to be DTensors"
_copy_set_value_to_dtensor(fqn, parallel_value, value)

return property(getter, setter)
Expand Down
Loading
Loading