-
Notifications
You must be signed in to change notification settings - Fork 9
Add numerics comparison script #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stack-info: PR: #259, branch: xmfan/stack/23
913dfc8 to
852996f
Compare
stack-info: PR: #259, branch: xmfan/stack/23
852996f to
df83fd6
Compare
df83fd6 to
c1a8c9e
Compare
stack-info: PR: #259, branch: xmfan/stack/23
stack-info: PR: #259, branch: xmfan/stack/23
c1a8c9e to
7ff2bf0
Compare
|
Have you verified numerics with the flag |
|
nope, for loss_fn, we would need to add it to the non-pp script and for schedule names, i'll need to validate them. will add a CLI flag to switch between schedules for now |
stack-info: PR: #259, branch: xmfan/stack/23
7ff2bf0 to
401c5d0
Compare
|
@sanketpurandare interleave1f1b and zbpp are both fine, dualpipev needs some minor logging changes. will do separately and add into ci for next pr |
Stacked PRs:
Add numerics comparison script from Devmate
Intended usage:
python examples/run_ds3_numerics_check.pyWhich creates a temp folder e.g. /tmp/ds3_numerics_check_ufc54rz8, then runs:
It currently warns, because there's a silly mismatch wrt buffer registration, where we have 4 freq_cis in the pp model. Once fixed, I can change it back to a RuntimeError, and we can add it into CI.